Test: refactor setup and get all tests passing #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
changed the title
kares
changed the title
5 tasks
kaisecheng
reviewed
Dec 30, 2021
| "host" => host, | ||
| "ssl_peer_metadata" => true, | ||
| "ssl_certificate_authorities" => [ certificate.ssl_cert ], | ||
| "ecs_compatibility" => 'disabled' |
There was a problem hiding this comment.
we don't have a test case for tls metadata in ecs mode, isn't it?
There was a problem hiding this comment.
might be elsewhere - recall writing this spec as specifically guarding against a NPE regression,
the bug surfaced regardless of ecs_compatibility and the test's intention isn't verifying ECS vs non-ECS field behavior (I understand it might seem so on first sight).
kaisecheng
approved these changes
Dec 30, 2021
yaauie
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back to 🟢
harder than expected due LogStash::ConfigurationError: File does not contain valid private key #443
refactored the Dockerfile to use the base file (from .ci) and have the extra
install opensslin.ci/setup.shhook